fix: appearance handling on iOS #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
force-pushed
the
fix/apperance-updates
branch
from
05e3ea2 to
b8effab
Compare
Member
Author
|
This PR also properly encapsulates tab bar styles (instead of app wide styling on UITabBar().appearance) you can now push a new screen with tab bar. CleanShot.2024-11-09.at.10.41.37.mp4 |
okwasniewski
force-pushed
the
fix/apperance-updates
branch
from
b8effab to
1f03434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix: #124
It's also a partial fix for #128, it appears that everything works properly with
scrollEdgeApperance="transparent".If we override
tabBar.scrollEdgeAppearancethen it's breaking. It is a bug in SwiftUI's tab view component which we can do nothing about 😢 (other than open a issue for apple)